Opened 3 years ago
Closed 3 years ago
#26864 closed defect (fixed)
Indentation error in Number Field
Reported by: | mwest | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | number fields | Keywords: | |
Cc: | Merged in: | ||
Authors: | Mckenzie West | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 61bb326 (Commits, GitHub, GitLab) | Commit: | 61bb326b6f639085d3d7b222e802487349610618 |
Dependencies: | Stopgaps: |
Description
Followup to a comment in #22148 to fix the indentation in numberfield.py within the solve_S_unit_equation function.
Change History (13)
comment:1 Changed 3 years ago by
- Branch set to u/mwest/indentation_error_in_number_field
comment:2 Changed 3 years ago by
- Commit set to f96362e479297bd812397164b82f6a48d7d8a9f7
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
Is the change "verbose" → "proof" intentional?
comment:4 follow-up: ↓ 5 Changed 3 years ago by
The change in documentation was done to match the actual function.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 3 years ago by
Replying to mwest:
The change in documentation was done to match the actual function.
Shouldn't the description be changed as well, then?
comment:6 in reply to: ↑ 5 Changed 3 years ago by
Replying to mmezzarobba:
Replying to mwest:
The change in documentation was done to match the actual function.
Shouldn't the description be changed as well, then?
I am not sure why it was proof instead of verbose, I have updated it to "verbose" so that it matches the functions in S_unit_solver.py.
comment:7 Changed 3 years ago by
- Status changed from needs_review to needs_work
The change verbose
-> proof
was correct, but also the description of the proof
parameter should be fixed.
comment:8 Changed 3 years ago by
- Commit changed from f96362e479297bd812397164b82f6a48d7d8a9f7 to 61bb326b6f639085d3d7b222e802487349610618
comment:9 Changed 3 years ago by
- Status changed from needs_work to needs_review
Ok, I now understand what is happening, everything is fixed.
comment:10 Changed 3 years ago by
comment:11 Changed 3 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
comment:12 Changed 3 years ago by
- Milestone changed from sage-8.5 to sage-8.7
comment:13 Changed 3 years ago by
- Branch changed from u/mwest/indentation_error_in_number_field to 61bb326b6f639085d3d7b222e802487349610618
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Fixed indentation of documentation in solve_S_unit_equation